Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module/jabba/1.0 #179

Open
wants to merge 88 commits into
base: master
Choose a base branch
from
Open

Module/jabba/1.0 #179

wants to merge 88 commits into from

Conversation

ppararaj
Copy link
Contributor

@ppararaj ppararaj commented Apr 14, 2021

Pull Request Checklists

Important: When opening a pull request, keep only the applicable checklist and delete all other sections.

Checklist for New Module

Required

  • I used the cookiecutter template and updated the placeholder rules.

  • The snakemake rules follow the design guidelines.

    • All references to the rules object (e.g. for input files) are wrapped with str().
  • Every rule in the module is either listed under localrules or has the threads and resources directives.

  • Input and output files are being symlinked into the CFG["inputs"] and CFG["outputs"] subdirectories, respectively.

  • I updated the final target rule (*_all) to include every output rule.

  • I explained important module design decisions in CHANGELOG.md.

  • I tested the module on real data for all supported seq_type values.

  • I updated the default.yaml configuration file to provide default values for each rule in the module snakefile.

  • I did not set any global wildcard constraints. Any/all wildcard constraints are set on a per-rule basis.

  • I ensured that all symbolic links are relative and self-contained (i.e. do not point outside of the repository).

  • I replaced every value that should (or might need to) be updated in the default configuration file with __UPDATE__.

  • I recursively searched for all comments containing TODO to ensure none were left. For example:

    grep -r TODO modules/<module_name>/1.0

If applicable

  • I added more granular output subdirectories.

  • I added rules to the reference_files workflow to generate any new reference files.

  • I added subdirectories with large intermediate files to the list of scratch_subdirectories in the default.yaml configuration file.

  • I updated the list of available wildcards for the input files in the default.yaml configuration file.

Checklist for Updated Module

To be completed.

@ppararaj
Copy link
Contributor Author

Completed execution on all the MCL genomes.

@Kdreval
Copy link
Collaborator

Kdreval commented Jan 22, 2022

@ppararaj can you please update if this is ready to go? There are some conflicts with master that needs to be resolved before merging, but does everything else is ok?

@ppararaj
Copy link
Contributor Author

@Kdreval I've resolved the merge conflict. Can you go over the config.yaml and make sure the conflict resolution didn't break anything?

@@ -138,9 +138,6 @@ tools:
gsutil:
conda_env: "envs/gsutil-4.53.yaml"
version: "4.53"
bedtools:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this bedtools got accidentally dropped, but otherwise looks good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appeared to be duplicated. There's an entry for bedtools above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it, thanks! So everything was pushed in this PR and this is the working version?

@Kdreval
Copy link
Collaborator

Kdreval commented Jul 26, 2024

I think @kmcoyle had some updates to this module? Can they be pushed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants